[DI] Unknown env prefix not recognized as such #33960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro0NL
changed the title
|
Thank you @ro0NL. |
nicolas-grekas
added a commit
that referenced
this pull request
Feb 4, 2020
This PR was submitted for the 4.3 branch but it was merged into the 4.4 branch instead. Discussion ---------- [DI] Unknown env prefix not recognized as such | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #... <!-- prefix each issue number with "Fix #", if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> This is a failing test to illustrate the difference between real and fake env vars when using an unknown prefix, followed by the `default` prefix. ``` %env(unknown:default::REAL)% // Unsupported env var prefix "unknown". %env(unknown:default::FAKE)% // null ``` For `default::FAKE` we get `null` at https://github.com/symfony/symfony/blob/38b9a27976d36c4ffbfeb9e666319d77ffc8b3c0/src/Symfony/Component/DependencyInjection/EnvVarProcessor.php#L103 which is then preserved at https://github.com/symfony/symfony/blob/38b9a27976d36c4ffbfeb9e666319d77ffc8b3c0/src/Symfony/Component/DependencyInjection/EnvVarProcessor.php#L123 need inspiration for a patch still :) Commits ------- 550819a [DI] Unknown env prefix not regornized as such
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a failing test to illustrate the difference between real and fake env vars when using an unknown prefix, followed by the
defaultprefix.For
default::FAKEwe getnullatsymfony/src/Symfony/Component/DependencyInjection/EnvVarProcessor.php
Line 103 in 38b9a27
which is then preserved at
symfony/src/Symfony/Component/DependencyInjection/EnvVarProcessor.php
Line 123 in 38b9a27
need inspiration for a patch still :)