[Form] Fix handling of empty_data's \Closure value in Date/Time form types

[yceruto]

Q	A
Branch?	3.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	Fix #33188
License	MIT
Doc PR	-

Basically this would solve the posibility to pass a \Closure to the empty_data option for Date/Time form types.

https://symfony.com/doc/current/reference/forms/types/form.html#empty-data
If a form is compound, you can set empty_data as an array, object or closure. See the How to Configure empty Data for a Form Class article for more details about these options.

Also related to #29182

[yceruto]

@xabbuh done, thanks!

[xabbuh]

What about doing the same as what you did in the DateType then?

if ($emptyData instanceof \Closure) {
    $lazyEmptyData = static function ($option) use ($emptyData) {
        return static function (FormInterface $form) use ($emptyData, $option) {
            $emptyData = $emptyData($form->getParent());
            return isset($emptyData[$option]) ? $emptyData[$option] : '';
        };
    };
    $dateOptions['empty_data'] = $lazyEmptyData('date');
} else {
    if (isset($emptyData['date'])) {
        $dateOptions['empty_data'] = $emptyData['date'];
    }

    if (isset($emptyData['time'])) {
        $timeOptions['empty_data'] = $emptyData['time'];
    }
}

[HeahDude]

To do that the $timeOptions initialization should be moved before the first empty data definition.

[HeahDude]

I can see there are conflicting comments from Nicolas and Christian, so maybe we should always set $lazyEmptyData base on the instance of once, then test if $lazyEmptyData is null to define the options.

[fabpot]

Thank you @yceruto.