[PhpUnitBridge] Fix running skipped tests expecting only deprecations #35489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
force-pushed
the
phpunit-null-testres
branch
3 times, most recently
from
8db376e
to
993c43e
Compare
fancyweb
reviewed
Jan 28, 2020
| @@ -196,7 +196,7 @@ public function addSkippedTest($test, \Exception $e, $time) | |||
|
|
|||
| public function startTest($test) | |||
| { | |||
| if (-2 < $this->state && ($test instanceof \PHPUnit\Framework\TestCase || $test instanceof TestCase)) { | |||
| if (-2 < $this->state && ($test instanceof \PHPUnit\Framework\TestCase || $test instanceof TestCase) && $test->getTestResultObject()) { | |||
There was a problem hiding this comment.
Don't we want to move this new condition where $test->getTestResultObject() is actually used? 🤔 There are other things in this if that works without a test result object.
There was a problem hiding this comment.
Right now it's not obvious to me what it means when the getTestResult() retval is null. I tend to think this code should not be reached at all, but I may be missing something (e.g. isolated tests) and then we should only skip adding failures on case by case basis. ping @nicolas-grekas
|
Thank you @chalasr. |
nicolas-grekas
force-pushed
the
phpunit-null-testres
branch
from
993c43e
to
6b02362
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Feb 3, 2020
…eprecations (chalasr) This PR was merged into the 3.4 branch. Discussion ---------- [PhpUnitBridge] Fix running skipped tests expecting only deprecations | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - If a test class has unsatisfied `@requires` and contains test methods expecting deprecation only, you get: > Fatal error: Uncaught Error: Call to a member function beStrictAboutTestsThatDoNotTestAnything() on null in ./symfony/symfony-dev/vendor/symfony/phpunit-bridge/Legacy/SymfonyTestsListenerTrait.php:229 Spotted in #34925's build. Commits ------- 6b02362 [Phpunit] Fix running skipped tests expecting only deprecations
This was referenced Feb 29, 2020
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a test class has unsatisfied
@requiresand contains test methods expecting deprecation only, you get:Spotted in #34925's build.