[Config][XmlReferenceDumper] Prevent potential \TypeError #35537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We don't handle dumping null names, that's what you mean? Any suggestions? |
We don't handle a
I don't think so. A test should be added once we support it.
No because the |
fancyweb
force-pushed
the
config-fix-xml-reference-dumper
branch
from
998b53e
to
e8ba15e
Compare
|
Thank you @fancyweb. |
nicolas-grekas
added a commit
that referenced
this pull request
Feb 3, 2020
…(fancyweb) This PR was merged into the 4.4 branch. Discussion ---------- [Config][XmlReferenceDumper] Prevent potential \TypeError | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | #34841 | License | MIT | Doc PR | - `$key` can be null and `setName()` is now typed with `string`. Fallbacking on an empty string restores the behavior (and output) of < 5.0. However, that shows that's a case we don't handle (yet) properly. But that's another task 😃 Commits ------- e8ba15e [Config][XmlReferenceDumper] Prevent potential \TypeError
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$keycan be null andsetName()is now typed withstring. Fallbacking on an empty string restores the behavior (and output) of < 5.0.However, that shows that's a case we don't handle (yet) properly. But that's another task 😃