[HttpClient] fix HttpClientDataCollector when handling canceled responses #35562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Feb 2, 2020
nicolas-grekas
commented
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix #35458 |
| License | MIT |
| Doc PR | - |
nicolas-grekas
force-pushed
the
hc-canceled
branch
from
3cb726d
to
303f9e5
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Feb 3, 2020
…celed responses (nicolas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [HttpClient] fix HttpClientDataCollector when handling canceled responses | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #35458 | License | MIT | Doc PR | - Commits ------- 303f9e5 [HttpClient] fix HttpClientDataCollector when handling canceled responses
|
@nicolas-grekas I know this has already been merged, but we encountered the same error in the following lines (123) where if ($trace['url'] === $info['url']) {
unset($info['url']);
}--> if ( ($info['url'] ?? null) === $trace['url']) {
unset($info['url']);
}Have not contributed yet, so i will probably not make the pr myself... |
|
You can do it, I promise :) |
nicolas-grekas
added a commit
that referenced
this pull request
Feb 11, 2020
…celed responses (thematchless) This PR was merged into the 4.4 branch. Discussion ---------- [HttpClient] fix HttpClientDataCollector when handling canceled responses | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - small addition to the already merged #35562 Commits ------- 7088ef7 [HttpClient] fix HttpClientDataCollector when handling canceled responses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.