[Validator] do not merge constraints within interfaces #35591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greedyivan
force-pushed
the
bugfix_22538_34
branch
3 times, most recently
from
d8fc004
to
ba54d3e
Compare
nvdbeek
approved these changes
Feb 5, 2020
xabbuh
requested changes
Apr 1, 2020
src/Symfony/Component/Validator/Mapping/Factory/LazyLoadingMetadataFactory.php
Outdated
Show resolved
Hide resolved
greedyivan
force-pushed
the
bugfix_22538_34
branch
from
ba54d3e
to
67f336b
Compare
xabbuh
approved these changes
Apr 9, 2020
fabpot
approved these changes
Apr 12, 2020
|
Thank you @greedyivan. |
This was referenced Apr 28, 2020
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix disables merge constraints within interfaces.
There is no reason to merge constraints from one interface to another because each class merges the constraints of all its interfaces. Only one check is needed is to eliminate all interfaces that comes from parent class to avoid duplication.