[Process] throw when PhpProcess::fromShellCommandLine() is used #35641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe it could be a good idea to submit a PR on the doc to add a warning about calling this method? 🤔 |
nicolas-grekas
approved these changes
Feb 7, 2020
nicolas-grekas
changed the title
fabpot
approved these changes
Feb 8, 2020
|
Thank you @Guikingone. |
fabpot
added a commit
that referenced
this pull request
Feb 8, 2020
… used (Guikingone) This PR was merged into the 4.4 branch. Discussion ---------- [Process] throw when PhpProcess::fromShellCommandLine() is used | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #35637 | License | MIT | Doc PR | None Close #35638 Final PR (rebased and tests added) Commits ------- 7f6d71c refactor(Process): fromShellCommandLine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #35638
Final PR (rebased and tests added)