[ErrorHandler] Never throw on warnings triggered by assert() and set assert.exception=1 in Debug::enable() #35645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…assert.exception=1 in Debug::enable()
Tobion
approved these changes
Feb 8, 2020
fabpot
approved these changes
Feb 8, 2020
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Feb 8, 2020
…() and set assert.exception=1 in Debug::enable() (nicolas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [ErrorHandler] Never throw on warnings triggered by assert() and set assert.exception=1 in Debug::enable() | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Because we don't use `assert()`, this is something we completely overlooked, but warnings triggered should not throw as there is already a dedicated exception mode when using `assert()`. This turns this exception mode to 1 in debug mode and logs the assert() warnings in prod. Commits ------- f18ef6c [ErrorHandler] Never throw on warnings triggered by assert() and set assert.exception=1 in Debug::enable()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we don't use
assert(), this is something we completely overlooked, but warnings triggered should not throw as there is already a dedicated exception mode when usingassert().This turns this exception mode to 1 in debug mode and logs the assert() warnings in prod.