[HttpClient] fix getting response content after its destructor throwed an HttpExceptionInterface #35674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Feb 11, 2020
…d an HttpExceptionInterface
nicolas-grekas
force-pushed
the
hc-fix
branch
from
6d1657b
to
0407d05
Compare
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Feb 11, 2020
…ctor throwed an HttpExceptionInterface (nicolas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [HttpClient] fix getting response content after its destructor throwed an HttpExceptionInterface | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Spotted by @B-Galati in #35659 (comment) Commits ------- 6d1657b [HttpClient] fix getting response content after its destructor throwed an HttpExceptionInterface
|
@nicolas-grekas Thank you so much for your reactivity 🙏 That's incredible! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotted by @B-Galati in #35659 (comment)