[Console] Handle zero row count in appendRow() for Table #35676
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
Table
is created and rendered with no rows (headers only) and subsequently rows are added usingappendRow()
, the first call toappendRow()
clears back one line too far., thus removing the last runThis is caused by
calculateRowCount()
not accounting for the fact that the footer separator is also the header separator when no rows are present.This PR works around the issue by checking to ensure that at least 1 row exists before including the footer separator in the row count.
Example
Command:
Before fix:
After fix: