Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Finder] Fix unix root dir issue #35693

Merged
merged 1 commit into from Feb 14, 2020
Merged

Conversation

chr-hertel
Copy link
Contributor

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #35683
License MIT

not quite sure about this one 馃

Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fabpot fabpot changed the base branch from 4.4 to 3.4 February 14, 2020 07:34
@fabpot
Copy link
Member

fabpot commented Feb 14, 2020

Thank you @chr-hertel.

fabpot added a commit that referenced this pull request Feb 14, 2020
This PR was submitted for the 4.4 branch but it was merged into the 3.4 branch instead.

Discussion
----------

[Finder] Fix unix root dir issue

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #35683
| License       | MIT

not quite sure about this one 馃

Commits
-------

9e43103 fix unix root dir issue
@fabpot fabpot merged commit 9e43103 into symfony:3.4 Feb 14, 2020
@chr-hertel chr-hertel deleted the bugfix/35683-unix-root branch February 14, 2020 08:35
@chr-hertel chr-hertel restored the bugfix/35683-unix-root branch February 14, 2020 08:36
This was referenced Feb 29, 2020
@chr-hertel chr-hertel deleted the bugfix/35683-unix-root branch October 23, 2022 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants