Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VarDumper] fixed DateCaster not displaying additional fields #35702

Merged
merged 1 commit into from Feb 15, 2020
Merged

[VarDumper] fixed DateCaster not displaying additional fields #35702

merged 1 commit into from Feb 15, 2020

Conversation

Veridis
Copy link

@Veridis Veridis commented Feb 13, 2020

Q A
Branch? 3.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #35699
License MIT
Doc PR ~

Here's the result with Holiday class

before after
before  after

@nicolas-grekas
Copy link
Member

Thank you @Veridis.

nicolas-grekas added a commit that referenced this pull request Feb 15, 2020
…lds (Makdessi Alex)

This PR was merged into the 3.4 branch.

Discussion
----------

[VarDumper] fixed DateCaster not displaying additional fields

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #35699
| License       | MIT
| Doc PR        | ~

----

Here's the result with [Holiday](https://github.com/azuyalabs/yasumi/blob/develop/src/Yasumi/Holiday.php) class

| before  | after
| ------- | -----
| ![before](https://user-images.githubusercontent.com/4425529/74445818-48f03d00-4e77-11ea-97e1-58d88ac52cba.png) | ![after](https://user-images.githubusercontent.com/4425529/74445825-4c83c400-4e77-11ea-8e8e-1fbbb1040438.png)

Commits
-------

f965971 [VarDumper] fixed DateCaster not displaying additional fields
@nicolas-grekas nicolas-grekas merged commit f965971 into symfony:3.4 Feb 15, 2020
@Veridis Veridis deleted the issue_35699 branch February 20, 2020 12:46
This was referenced Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants