[HttpFoundation] fix not sending Content-Type header for 204 responses #35709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobion
commented
Feb 13, 2020
| } else { | ||
| // Content-type based on the Request | ||
| if (!$headers->has('Content-Type')) { | ||
| $format = $request->getPreferredFormat(); | ||
| $format = $request->getPreferredFormat(null); |
There was a problem hiding this comment.
The Content-Type gets set to html anyway a few lines below (284). So we don't to ask for the html default here. Otherwise line 284 is basically unreachable.
Tobion
force-pushed
the
no-content-type-on-204
branch
from
e868336
to
06f5a11
Compare
fabpot
approved these changes
Feb 14, 2020
fabpot
reviewed
Feb 14, 2020
| @@ -267,10 +267,12 @@ public function prepare(Request $request) | |||
| $this->setContent(null); | |||
| $headers->remove('Content-Type'); | |||
| $headers->remove('Content-Length'); | |||
| // prevent PHP from sending the Content-Type header based on default_mimetype | |||
| ini_set('default_mimetype', ''); | |||
There was a problem hiding this comment.
This should be merged in 3.4 as well, right?
|
Thank you @Tobion. |
fabpot
added a commit
that referenced
this pull request
Feb 14, 2020
…04 responses (Tobion)
This PR was merged into the 4.4 branch.
Discussion
----------
[HttpFoundation] fix not sending Content-Type header for 204 responses
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets |
| License | MIT
| Doc PR |
`$headers->remove('Content-Type')` did not actually work because PHP sends the Content-Type header based on the https://www.php.net/manual/en/ini.core.php#ini.default-mimetype ini setting anyway (which defaults to html). So we need to disable this ini for empty responses.
Commits
-------
06f5a11 [HttpFoundation] fix not sending Content-Type header for 204 responses
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$headers->remove('Content-Type')did not actually work because PHP sends the Content-Type header based on the https://www.php.net/manual/en/ini.core.php#ini.default-mimetype ini setting anyway (which defaults to html). So we need to disable this ini for empty responses.