[HttpClient] Correctly remove trace level options for HttpCache #35714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschempp
changed the title
nicolas-grekas
approved these changes
Feb 14, 2020
fabpot
approved these changes
Feb 15, 2020
|
Thank you @aschempp. |
fabpot
added a commit
that referenced
this pull request
Feb 15, 2020
…Cache (aschempp) This PR was merged into the 4.4 branch. Discussion ---------- [HttpClient] Correctly remove trace level options for HttpCache | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - The `HttpCache` component allows to [configure a trace level](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/HttpKernel/HttpCache/HttpCache.php#L46). Due to the behavior of `CachingHttpClient`, options that are meant for the `HttpCache` must be unset before preparing the request. Currently these options can't be set, because `HttpClient` errors with invalid configuration options. Commits ------- 618cd80 Correctly remove trace level options for HttpCache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
HttpCachecomponent allows to configure a trace level. Due to the behavior ofCachingHttpClient, options that are meant for theHttpCachemust be unset before preparing the request. Currently these options can't be set, becauseHttpClienterrors with invalid configuration options.