[HttpKernel] Set previous exception when rethrown from controller resolver #35722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Feb 15, 2020
fabpot
force-pushed
the
controller_invalid_argument_exception
branch
from
ab06cd9
to
87d51c1
Compare
|
Thank you @danut007ro. |
fabpot
added a commit
that referenced
this pull request
Feb 15, 2020
…troller resolver (danut007ro) This PR was submitted for the 4.4 branch but it was merged into the 3.4 branch instead. Discussion ---------- [HttpKernel] Set previous exception when rethrown from controller resolver | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | License | MIT If an `\InvalidArgumentException` is catched by ControllerResolver a new one is thrown. The old exception is not added as `previous` parameter on the new one so it is not visible on the exception page. This pull request adds old exception as previous on the new one, so it is also visible on the exception page. Thank you. Commits ------- 87d51c1 Set previous exception when rethrown from controller resolver
This was referenced Feb 29, 2020
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an
\InvalidArgumentExceptionis catched by ControllerResolver a new one is thrown. The old exception is not added aspreviousparameter on the new one so it is not visible on the exception page. This pull request adds old exception as previous on the new one, so it is also visible on the exception page.Thank you.