Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PhpUnitBridge] Use trait instead of extending deprecated class #35787

Merged

Conversation

marcello-moenkemeyer
Copy link
Contributor

@marcello-moenkemeyer marcello-moenkemeyer commented Feb 19, 2020

Q A
Branch? 3.4
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #32086
License MIT
Doc PR

Use TestListenerDefaultImplementation instead of deprecated BaseTestListener for CoverageListenerForV6

As this is my very first pull request for this project, I'd be very glad for hints and suggestions in case I missed something.

@nicolas-grekas nicolas-grekas changed the title #32086 [PhpUnitBridge] Use trait instead of extending deprecated class [PhpUnitBridge] Use trait instead of extending deprecated class Feb 19, 2020
@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Feb 19, 2020
@fabpot fabpot force-pushed the 32086-fix-phpunit-v6-deprecation branch from d135004 to 034e1de Compare February 21, 2020 08:02
@fabpot
Copy link
Member

fabpot commented Feb 21, 2020

Thank you @marcello-moenkemeyer.

@fabpot fabpot merged commit 8197d9a into symfony:3.4 Feb 21, 2020
@marcello-moenkemeyer marcello-moenkemeyer deleted the 32086-fix-phpunit-v6-deprecation branch February 21, 2020 13:17
This was referenced Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants