Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security] Prevent TypeError in case RememberMetoken has no attached user #35792

Merged
merged 1 commit into from Feb 20, 2020
Merged

[Security] Prevent TypeError in case RememberMetoken has no attached user #35792

merged 1 commit into from Feb 20, 2020

Conversation

nikophil
Copy link
Contributor

Q A
Branch? 3.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #33472
License MIT

@chalasr chalasr changed the title fix remember me [Security] Prevent TypeError in case RememberMetoken has no attached user Feb 20, 2020
@chalasr chalasr added this to the 3.4 milestone Feb 20, 2020
chalasr
chalasr approved these changes Feb 20, 2020
View reviewed changes
Copy link
Member

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed on your fork to make it throws a logic exception instead of skipping silently. 👍

@chalasr
Copy link
Member

chalasr commented Feb 20, 2020

Thank you @nikophil.

@chalasr chalasr merged commit aa3637d into symfony:3.4 Feb 20, 2020
This was referenced Feb 29, 2020
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nikophil @chalasr @carsonbot