Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.4][DoctrineBridge] Use new Types::* constants and support new json type #35817

Merged

Conversation

fancyweb
Copy link
Contributor

Q A
Branch? 3.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

All Type::* constants were moved and deprecated. This PR makes sure we use the good ones when they exist so we are prepared for their removal. It allows to be deprecation free. If deprecated constants could be detected, we would have failing tests 😄

Also, json_array was deprecated and renamed to json, so I added support for this new type.

Some new components also use these constants on upper branches, so I will submit PRs there.

@fancyweb
Copy link
Contributor Author

I think fabbot failures should be ignored based on the existant code.

@fancyweb fancyweb force-pushed the doctrine-bridge-types-constants branch from 55baa60 to eb6e219 Compare February 21, 2020 16:54
@ogizanagi ogizanagi added this to the 3.4 milestone Feb 21, 2020
@fancyweb fancyweb force-pushed the doctrine-bridge-types-constants branch from 04649fd to 3e35fa5 Compare February 24, 2020 13:11
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(false positive from fabbot)

@nicolas-grekas
Copy link
Member

Thank you @fancyweb.

@nicolas-grekas nicolas-grekas merged commit 9819814 into symfony:3.4 Feb 24, 2020
@fancyweb fancyweb deleted the doctrine-bridge-types-constants branch February 24, 2020 14:05
@nicolas-grekas
Copy link
Member

I failed to merge this in 4.4, please submit for 4.4 in #35819 or in a separate PR :)

fabpot added a commit that referenced this pull request Feb 25, 2020
…rt new json types (fancyweb)

This PR was merged into the 4.4 branch.

Discussion
----------

[4.4][DoctrineBridge] Use new Types::* constants and support new json types

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | #35817 (comment)
| License       | MIT
| Doc PR        | -

Commits
-------

ddf3353 [4.4][DoctrineBridge] Use new Types::* constants and support new json type
This was referenced Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants