Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Debug][ErrorHandler] improved deprecation notices for methods new args and return type #35832

Merged
merged 1 commit into from Feb 24, 2020
Merged

[Debug][ErrorHandler] improved deprecation notices for methods new args and return type #35832

merged 1 commit into from Feb 24, 2020

Conversation

HeahDude
Copy link
Contributor

@HeahDude HeahDude commented Feb 23, 2020 •
edited

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets ~
License MIT
Doc PR ~

I don't know if this should be considered a bug fix or a feature.

@HeahDude HeahDude force-pushed the debug_class-tweak-dreprecation_notice branch from 1f25db4 to 548eb36 Compare February 23, 2020 12:20
@HeahDude HeahDude changed the title [Error handler] improved deprecation notices for methods new args and return type [ErrorHandler] improved deprecation notices for methods new args and return type Feb 23, 2020
chalasr
chalasr approved these changes Feb 23, 2020
View reviewed changes
Copy link
Member

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for 4.4 I'd say

@HeahDude HeahDude changed the base branch from master to 4.4 February 23, 2020 13:51
@HeahDude HeahDude force-pushed the debug_class-tweak-dreprecation_notice branch from 548eb36 to c6d9f30 Compare February 23, 2020 13:53
@HeahDude
Copy link
Contributor Author

I've changed the target.

@HeahDude HeahDude force-pushed the debug_class-tweak-dreprecation_notice branch from c6d9f30 to e3b1926 Compare February 23, 2020 14:08
@HeahDude HeahDude changed the title [ErrorHandler] improved deprecation notices for methods new args and return type [Debug][ErrorHandler] improved deprecation notices for methods new args and return type Feb 23, 2020
@HeahDude
Copy link
Contributor Author

I've fixed the tests in the Debug component too though.

@HeahDude HeahDude force-pushed the debug_class-tweak-dreprecation_notice branch from 4a22ad8 to 875d479 Compare February 23, 2020 14:30
@HeahDude HeahDude force-pushed the debug_class-tweak-dreprecation_notice branch from 875d479 to 83d4aa7 Compare February 23, 2020 14:41
@chalasr chalasr added this to the 4.4 milestone Feb 23, 2020
@nicolas-grekas
Copy link
Member

Thank you @HeahDude.

@nicolas-grekas nicolas-grekas merged commit da28445 into symfony:4.4 Feb 24, 2020
@HeahDude HeahDude deleted the debug_class-tweak-dreprecation_notice branch February 24, 2020 15:47
This was referenced Feb 29, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@yceruto yceruto yceruto approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@HeahDude @nicolas-grekas @yceruto @chalasr @carsonbot