[Routing] Prevent localized routes _locale default & requirement from being overridden #35928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… being overridden
fancyweb
force-pushed
the
routing-prevent-_locale-override
branch
from
e079d38
to
096dc0a
Compare
stof
approved these changes
Mar 2, 2020
|
Thank you @fancyweb. |
HeahDude
reviewed
Mar 2, 2020
| @@ -376,6 +376,10 @@ public function setDefaults(array $defaults) | |||
| */ | |||
| public function addDefaults(array $defaults) | |||
| { | |||
| if (isset($defaults['_locale']) && $this->isLocalized()) { | |||
| unset($defaults['_locale']); | |||
There was a problem hiding this comment.
What about throwing? (same in other places)
There was a problem hiding this comment.
It would be a BC break, and more importantly it would forbid legit use cases where one imports several routes and some of them are localized.
There was a problem hiding this comment.
I don't understand how this is breaking BC while we are already making it a noop here. Instead of legit use I see a silent failure, which could be reported at compile time for something wrongly configured.
There was a problem hiding this comment.
There is no error on the userland side, reporting an exception would break legit use cases as I mentioned also. This is a bug, not a userland issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we have configured a localized route, its default _locale and _locale requirement should not be modified to ensure it works as expected.