[Form] Handle false as empty value on expanded choices #35938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fancyweb
force-pushed
the
form-false-is-empty-34
branch
from
1919349
to
4874c23
Compare
HeahDude
reviewed
Mar 4, 2020
src/Symfony/Component/Form/Extension/Core/Type/CheckboxType.php
Outdated
Show resolved
Hide resolved
fancyweb
force-pushed
the
form-false-is-empty-34
branch
from
4874c23
to
1a366bc
Compare
xabbuh
approved these changes
Mar 7, 2020
HeahDude
approved these changes
Mar 8, 2020
|
Thank you @fancyweb. |
nicolas-grekas
added a commit
that referenced
this pull request
Mar 19, 2020
This PR was merged into the 5.1-dev branch. Discussion ---------- [Form][CheckboxType] Remove _false_is_empty flag | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Cleanup of #35938. Commits ------- 6fac6d4 [Form][CheckboxType] Remove _false_is_empty flag
symfony-splitter
pushed a commit
to symfony/form
that referenced
this pull request
Mar 19, 2020
This PR was merged into the 5.1-dev branch. Discussion ---------- [Form][CheckboxType] Remove _false_is_empty flag | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Cleanup of symfony/symfony#35938. Commits ------- 6fac6d4086 [Form][CheckboxType] Remove _false_is_empty flag
This was referenced Mar 27, 2020
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the 3.4 version of #32747. The tests are the same. The added code has to be removed from master (if accepted).