[DI] ignore extra tags added by autoconfiguration in PriorityTaggedServiceTrait

[nicolas-grekas]

Q	A
Branch?	4.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	Fix #35916, Fix #35953
License	MIT
Doc PR	-

[alex-dev]

Seems to work but...

• There are no TypedReference anymore. It may or may not matter.
• Reflection are reloaded everytime rather than at first time needed. Worst case is two calls to $container->getReflectionClass(), $container->getParameterBag()->resolveValue(). It should not matter much.
• $index will always have a value: line 89 - 91 are redundant. This will cause all service iterables to have service id as key (assuming they don't have a better key). Most of the complexity behind last implementation was to keep behavior the same as far as key goes.

[nicolas-grekas]

Thanks for the review

There are no TypedReference anymore. It may or may not matter.

Yep, doesn't matter.

Reflection are reloaded everytime

$container->getReflectionClass() already has a cache

$index will always have a value: line 89 - 91 are redundant

nope, see line 70

[alex-dev]

nope, see line 70

Doh! Everything seems good.

[Jamesking56]

Can we expect a release of this soon? We've had to hold upgrading to 4.4.5 due to this