Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dependency-injection] CustomNormalizer not injected until set with priority #35991

Closed
metfan opened this issue Mar 6, 2020 · 3 comments
Closed

Comments

@metfan
Copy link

metfan commented Mar 6, 2020

Symfony version(s) affected: 4.4.5

Description
After upgrade from 4.4.4 to 4.4.5, I see my app crashed because of missing CustomNormalizer.
I must add priority on the tag to see this normalizer injected in Serializer.

How to reproduce
With this simple config in service.yaml CustomeNormalizer is injected to Serializer before 4.4.5

Symfony\Component\Serializer\Normalizer\CustomNormalizer:

with 4.4.5 I must write:

Symfony\Component\Serializer\Normalizer\CustomNormalizer:
    tags:
        - { name: serializer.normalizer, priority: 100 }
@metfan
Copy link
Author

metfan commented Mar 6, 2020

probably related to #35916

@metfan metfan changed the title [Serializer] CustomNormalizer not injected until set with priority [Dependency-injection] CustomNormalizer not injected until set with priority Mar 6, 2020
@xabbuh
Copy link
Member

xabbuh commented Mar 7, 2020

@metfan Can you confirm that #35957 also fixes this issue?

@metfan
Copy link
Author

metfan commented Mar 9, 2020

@xabbuh yes #35957 fix this issue, I just checked.

@metfan metfan closed this as completed Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants