Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpKernel] Fix support for single-colon syntax for controllers #36017

Merged
merged 1 commit into from Mar 11, 2020

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? master for features / 3.4, 4.4 or 5.0 for bug fixes
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #35983
License MIT
Doc PR -

This reverts commit 6bb6473, reversing
changes made to 4cce23d.

As spotted by @stof in #35983 (comment)

@nicolas-grekas nicolas-grekas changed the title Revert "minor #35559 [FrameworkBundle] remove mention of the old Controller class (nicolas-grekas)" Fix support for single-colon syntax for controllers Mar 10, 2020
@nicolas-grekas nicolas-grekas changed the title Fix support for single-colon syntax for controllers [HttpKernel] Fix support for single-colon syntax for controllers Mar 10, 2020
@stof
Copy link
Member

stof commented Mar 10, 2020

I would restore the comment See Symfony\Component\HttpKernel\Controller\ContainerControllerResolver (just not the Deprecated since 4.1 part which was wrong)

…ld Controller class (nicolas-grekas)"

This reverts commit 6bb6473, reversing
changes made to 4cce23d.
@nicolas-grekas
Copy link
Member Author

OK, updated.

@fabpot
Copy link
Member

fabpot commented Mar 11, 2020

Thank you @nicolas-grekas.

@fabpot fabpot merged commit ca41e35 into symfony:5.0 Mar 11, 2020
@nicolas-grekas nicolas-grekas deleted the fixcontrollernotation branch March 13, 2020 11:28
@fabpot fabpot mentioned this pull request Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants