[PropertyAccess][DX] Improved errors when reading uninitialized properties #36073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeahDude
force-pushed
the
property_access-better-uninitialized_errors
branch
2 times, most recently
from
f947dc5
to
4d65001
Compare
HeahDude
changed the title
|
This diff should better be reviewed without whitespace changes. |
HeahDude
force-pushed
the
property_access-better-uninitialized_errors
branch
2 times, most recently
from
63b6c72
to
080500d
Compare
HeahDude
force-pushed
the
property_access-better-uninitialized_errors
branch
from
080500d
to
a71023b
Compare
fabpot
approved these changes
Mar 16, 2020
|
Thank you @HeahDude. |
fabpot
added a commit
that referenced
this pull request
Mar 18, 2020
…ception` (HeahDude) This PR was merged into the 5.1-dev branch. Discussion ---------- [PropertyAccess][DX] Added an `UninitializedPropertyException` | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | ~ | License | MIT | Doc PR | TODO Feature version of #36073 for master. Again, better be reviewed without whitespace changes, thanks! Commits ------- 2b2fd12 [PropertyAccess] Added an `UninitializedPropertyException`
This was referenced Mar 27, 2020
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to fix #36051 by providing better error messages when trying to read uninitialized properties either via calling a return-type-hinted method from PHP 7.0 or by accessing public-typed properties from PHP 7.4.
It would be nice to have a proper exception class in master.