[Profiler] Fix profiler nullable string type

[mRoca]

Q	A
Branch?	5.0
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	n/a
License	MIT
Doc PR	-

This PR fixes nullable string types in setter for the Profile class.

The detected issue comes from the Profiler class :

$profile->setIp($request->getClientIp()); // string or null

The corresponding return types for the Profile getters are allready good:

    /**
     * Returns the IP.
     *
     * @return string|null The IP
     */
    public function getIp()
    {
        return $this->ip;
    }

[Kocal]

Or maybe we can call ->setIp() only when $request->getClientIp() is not null?

[nicolas-grekas]

Setting the IP or URL to null doesn't look useful from the pov of the API, does it? How did you spot this?

[mRoca]

I've spotted it by calling the fpm agent with cgi-fcgi (for container cache warmup & docker healthcheck):

REDIRECT_STATUS=true SCRIPT_FILENAME=/srv/public/index.php HTTP_HOST=127.0.0.1 REQUEST_URI=/ REQUEST_METHOD=GET HTTP_USER_AGENT=probe cgi-fcgi -bind -connect 127.0.0.1:9001

This line command won't work because of this type bug, as $request->getClientIp() parses the $_SERVER['REMOTE_ADDR'] value. But if I add the corresponding header REMOTE_ADDR=127.0.0.1 to the command, everything is fine.

[fabpot]

Thank you @mRoca.