[Http Foundation] Fix clear cookie samesite #36173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Mar 23, 2020
|
Thank you @guillbdx. |
Merged
fabpot
added a commit
that referenced
this pull request
Mar 30, 2020
… delete_cookies (wouterj) This PR was merged into the 3.4 branch. Discussion ---------- [Security/Http] Allow setting cookie security settings for delete_cookies | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #36243 (comment) | License | MIT | Doc PR | tbd Similar to #36173 and #36175. This is needed for Chrome 80 compatibility. My only question is whether we should introduce these specific settings, or somehow fetch them from `framework.session`? Commits ------- a696d1f [Security/Http] Allow setting cookie security settings for delete_cookies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Chrome Update 80, Cookies are required to be
secureandsamesite=nonefor cross site requests. However they are defaulted tosamesite=laxif the samesite attribute is not set. In other words: developer has to explicitely opt-in forsamesite=nonein the case of a cross site request.More details: https://chromestatus.com/feature/5088147346030592
We add the
samesiteargument toclearCookiemethod to allow developer to explicitely set this value.