[Validator] Fixed calling getters before resolving groups #36245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HeahDude
commented
Mar 27, 2020
HeahDude
commented
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix #9939 |
| License | MIT |
| Doc PR | ~ |
HeahDude
force-pushed
the
validator-fix-getters-in-sequence
branch
from
675b779
to
5741d3e
Compare
HeahDude
commented
Mar 27, 2020
src/Symfony/Component/Validator/Validator/PropertyCandidate.php
Outdated
Show resolved
Hide resolved
xabbuh
reviewed
Mar 28, 2020
src/Symfony/Component/Validator/Tests/Validator/RecursiveValidatorTest.php
Outdated
Show resolved
Hide resolved
xabbuh
reviewed
Mar 28, 2020
src/Symfony/Component/Validator/Tests/Validator/RecursiveValidatorTest.php
Outdated
Show resolved
Hide resolved
HeahDude
force-pushed
the
validator-fix-getters-in-sequence
branch
2 times, most recently
from
6c68c39
to
4c91f52
Compare
xabbuh
approved these changes
Mar 28, 2020
HeahDude
force-pushed
the
validator-fix-getters-in-sequence
branch
from
4c91f52
to
e802cf8
Compare
HeahDude
force-pushed
the
validator-fix-getters-in-sequence
branch
from
e802cf8
to
edcfd60
Compare
chalasr
approved these changes
Mar 30, 2020
|
Thank you @HeahDude. |
nicolas-grekas
added a commit
that referenced
this pull request
Apr 18, 2020
This PR was merged into the 3.4 branch. Discussion ---------- [Form] Fixed handling groups sequence validation | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | FIx #9939 (comment), Fix #35556 | License | MIT | Doc PR | ~ This is not the same as the original issue fixed by #36245, that was reported in #9939 (comment). The form also fails to cascade sequence validation properly because each nested field is validated against the sequence, and one can fail at a step independently from another which could failed in another step. I've added a lot of tests to ensure this is working properly and tested in a website skeleton too. This PR aims to close #35556 which tries to fix the same issue but afterwards in its implementation as said in #35556 (comment). Commits ------- dfb61c2 [Form] Fixed handling groups sequence validation
This was referenced Apr 28, 2020
Merged
Merged
Merged
|
this is buggy. it breaks traversal of getters returning collections annotated with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.