Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the reporting of deprecations in twig:lint #36265

Merged
merged 1 commit into from Mar 31, 2020

Conversation

stof
Copy link
Member

@stof stof commented Mar 30, 2020

Q A
Branch? 4.4 (the --show-deprecations option does not exist in 3.4)
Bug fix? yes
New feature? no
Deprecations? no
Tickets n/a
License MIT
Doc PR n/a
  • ensure that the message is rendered when the line detection fails and we end up with 0 as line number (the implementation also deals with -1 which is sometimes used by Twig for errors when it does not know the line, even though this should not happen for compile-time errors).
  • fix the detection of the line number when the number is at the end of the sentence, which happens for the deprecation of filters for instance.

@nicolas-grekas nicolas-grekas added this to the 4.4 milestone Mar 30, 2020
@stof stof force-pushed the fix_twig_deprecation_reporting branch from 8910be7 to 8b1b8af Compare March 30, 2020 14:53
- ensure that the message is rendered when the line detection fails and
  we end up with 0 as line number (the implementation also deals with -1
  which is sometimes used by Twig for errors when it does not know the
  line, even though this should not happen for compile-time errors).
- fix the detection of the line number when the number is at the end of
  the sentence, which happens for the deprecation of filters for
  instance.
@nicolas-grekas
Copy link
Member

Thank you @stof.

@nicolas-grekas nicolas-grekas merged commit a5af8f6 into symfony:4.4 Mar 31, 2020
@stof stof deleted the fix_twig_deprecation_reporting branch April 1, 2020 17:52
This was referenced Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants