[Validator] Fixed default group for nested composite constraints #36365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeahDude
force-pushed
the
validator/fix-nested-composite
branch
from
c9ac5c3
to
2fced30
Compare
HeahDude
force-pushed
the
validator/fix-nested-composite
branch
from
2fced30
to
4a79a21
Compare
jannes-io
approved these changes
Apr 6, 2020
xabbuh
reviewed
Apr 8, 2020
HeahDude
force-pushed
the
validator/fix-nested-composite
branch
from
4a79a21
to
117ee34
Compare
xabbuh
approved these changes
Apr 8, 2020
fabpot
approved these changes
Apr 12, 2020
|
Thank you @HeahDude. |
This was referenced Apr 28, 2020
Merged
Merged
Merged
nicolas-grekas
added a commit
that referenced
this pull request
May 30, 2020
…tional) constraints (xabbuh) This PR was merged into the 3.4 branch. Discussion ---------- [Validator] never directly validate Existence (Required/Optional) constraints | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #36637 #36723 | License | MIT | Doc PR | Using `Optional` or `Required` like "regular" constraints does not make any sense, but doing so didn't break before #36365. I suggest to ignore them for now and deprecate using them outside the `Collection` constraint in 5.2. Commits ------- d333aae never directly validate Existence (Required/Optional) constraints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take a breath: when composite constraints are nested in a parent composite constraint without having non composite nested constraints (i.e empty), then the default group is not added, making the validator failing to validate in any group (including default), because there is no group at all, which should never happen.