Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Process] Fixed input/output error on PHP 7.4 #36380

Merged
merged 1 commit into from Apr 10, 2020

Conversation

mbardelmeijer
Copy link
Contributor

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #34945
License MIT
Doc PR

This PR aims to fix the error from #34945, but i'm unsure if this is the best solution. The issue is that on PHP 7.4 the input/output error may come up.

php.net/manual/en/migration74.incompatible.php#migration74.incompatible.core.fread-fwrite

fread() and fwrite() will now return FALSE if the operation failed. Previously an empty string or 0 was returned. EAGAIN/EWOULDBLOCK are not considered failures. These functions now also raise a notice on failure, such as when trying to write to a read only file resource.

@nicolas-grekas
Copy link
Member

Thank you @mbardelmeijer.

@nicolas-grekas nicolas-grekas merged commit f2d4a29 into symfony:4.4 Apr 10, 2020
This was referenced Apr 28, 2020
bcremer added a commit to bcremer/deployer that referenced this pull request May 12, 2020
The symfony/process v5.0.8 release contains a fix for the annoying
input/output error messages on PHP 7.4.

Example:
fread(): read of 8192 bytes failed with errno=5 Input/output error

See: symfony/symfony#36380

Package operations: 0 installs, 7 updates, 0 removals
  - Updating symfony/polyfill-php73 (v1.15.0 => v1.16.0)
  - Updating symfony/polyfill-mbstring (v1.15.0 => v1.16.0)
  - Updating symfony/console (v5.0.7 => v5.0.8)
  - Updating symfony/process (v5.0.7 => v5.0.8)
  - Updating symfony/polyfill-ctype (v1.15.0 => v1.16.0)
  - Updating symfony/yaml (v5.0.7 => v5.0.8)
  - Updating phpdocumentor/reflection-common (2.0.0 => 2.1.0)
antonmedv pushed a commit to deployphp/deployer that referenced this pull request May 15, 2020
The symfony/process v5.0.8 release contains a fix for the annoying
input/output error messages on PHP 7.4.

Example:
fread(): read of 8192 bytes failed with errno=5 Input/output error

See: symfony/symfony#36380

Package operations: 0 installs, 7 updates, 0 removals
  - Updating symfony/polyfill-php73 (v1.15.0 => v1.16.0)
  - Updating symfony/polyfill-mbstring (v1.15.0 => v1.16.0)
  - Updating symfony/console (v5.0.7 => v5.0.8)
  - Updating symfony/process (v5.0.7 => v5.0.8)
  - Updating symfony/polyfill-ctype (v1.15.0 => v1.16.0)
  - Updating symfony/yaml (v5.0.7 => v5.0.8)
  - Updating phpdocumentor/reflection-common (2.0.0 => 2.1.0)

Co-authored-by: Benjamin Cremer <benjamin.cremer@check24.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants