Allowing empty secrets to be set #36400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
commented
Apr 9, 2020
| @@ -106,12 +111,6 @@ protected function execute(InputInterface $input, OutputInterface $output): int | |||
| throw new \InvalidArgumentException(sprintf('File is not readable: "%s".', $file)); | |||
| } | |||
|
|
|||
| if (null === $value) { | |||
There was a problem hiding this comment.
If you look above at the possible ways to set $value, a null value was only possible when using the askHidden() interactive prompt. So now, it should not be possible to have null at this point.
weaverryan
force-pushed
the
fix-allow-empty-secrets
branch
from
f2c9e66
to
c9bf0c8
Compare
nicolas-grekas
approved these changes
Apr 9, 2020
javiereguiluz
approved these changes
Apr 9, 2020
Tobion
approved these changes
Apr 9, 2020
|
Thank you @weaverryan. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting secrets to an empty string is a valid value - you can already do this by consuming from an empty file or
stdinwith no input. But it's not currently possible to use the interactive prompt to set a secret to an empty string. This fixes that.