[PhpUnitBridge] add PolyfillTestCaseTrait::expectExceptionMessageMatches to provide FC with recent phpunit versions #36408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soyuka
force-pushed
the
fix/phpunit-bridge-expectexceptionmessagematches
branch
from
ab980a9
to
c7a2aad
Compare
nicolas-grekas
changed the title
|
I suppose the codebase should be updated accordingly? |
|
you mean change expectExceptionMessageRegExp to expectExceptionMessageMatches? |
|
@soyuka yes, in the whole Symfony code base. |
soyuka
commented
Apr 15, 2020
…hes to provide FC with recent phpunit versions
nicolas-grekas
force-pushed
the
fix/phpunit-bridge-expectexceptionmessagematches
branch
from
286518a
to
cfd5a29
Compare
|
Thank you @soyuka. |
|
@soyuka would you mind contributing a rule to php-cs-fixer so that this is enforced automatically in the future please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
expectExceptionMessageRegExp is deprecated coming phpunit 8.5.3 see sebastianbergmann/phpunit#4133
Not sure if I need to add something else lmk.