[HttpClient] fix HTTP/2 support on non-SSL connections - CurlHttpClient only #36422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Apr 11, 2020
nicolas-grekas
commented
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix #36419 |
| License | MIT |
| Doc PR | - |
fabpot
approved these changes
Apr 12, 2020
|
Thank you @nicolas-grekas. |
nicolas-grekas
added a commit
that referenced
this pull request
Jul 3, 2020
… (fancyweb) This PR was merged into the 4.4 branch. Discussion ---------- [HttpClient][CurlHttpClient] Fix http_version option usage | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | #37402 | License | MIT | Doc PR | - Ref #36422 If the scheme is https, we should only set http version 2.0 if the http_version is not specified. Commits ------- 2676902 [HttpClient][CurlHttpClient] Fix http_version option usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.