Remove return type for Twig function workflow_metadata() #36447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technically it is allowed to have metadata other than string, even data that does not cast to string, like an array. Also see symfony#36391
lyrixx
approved these changes
Apr 14, 2020
stof
approved these changes
Apr 14, 2020
noniagriconomie
approved these changes
Apr 14, 2020
xabbuh
approved these changes
Apr 15, 2020
fabpot
approved these changes
Apr 15, 2020
|
Thank you @gisostallenberg. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technically it is allowed to have metadata other than string, even data that does not cast to string, like an array.
The workflow metadata store can contain not only strings, but setting nested metadata results in an error when workflow_metadata() is used in Twig.
Also see #36391