[Filesystem] Handle paths on different drives #36497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you rebase+retarget the PR for branch 3.4 please? It looks like the bug is there also (and we'll merge 3.4 up to master eventually so 5.0 will get the fix too.) |
javiereguiluz
approved these changes
Apr 20, 2020
crishoj
requested review from
dunglas,
jderusse,
lyrixx,
sroze and
xabbuh
as code owners
crishoj
force-pushed
the
paths-on-different-drives
branch
from
886f47f
to
88f47ff
Compare
|
Rebased and retargeted to 3.4. |
nicolas-grekas
approved these changes
May 4, 2020
nicolas-grekas
force-pushed
the
paths-on-different-drives
branch
from
ff76787
to
00e727a
Compare
|
Thank you @crishoj. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
makePathRelativestrips and ignores the drive letters given Windows paths on different drives, resulting in a relative path which does not resolve to the desired target.This PR makes
makePathRelativenotice paths on different drives, and return the full (absolute) target path in case instead.