[FrameworkBundle] debug:autowiring: Fix wrong display when using class_alias #36519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
commented
Apr 21, 2020
|
|
||
| $tester = new ApplicationTester($application); | ||
| $tester->run(['command' => 'debug:autowiring', 'search' => 'ClassAlias', '--all' => true]); | ||
| $this->assertStringContainsString('Symfony\Bundle\FrameworkBundle\Tests\Fixtures\ClassAliasExampleClass (public)', $tester->getDisplay()); |
There was a problem hiding this comment.
Before the patch, the output was simple:
Symfony\Bundle\FrameworkBundle\Tests\Fixtures\ClassAliasTargetClass
It would resolve ClassAliasExampleClass to ClassAliasTargetClass. To make matters worse, because ClassAliasTargetClass is not an alias name in the system (it's not even a service in the system), it doesn't print the service id (or show up unless you pass --all) because it looks (incorrectly) like a concrete service.
weaverryan
force-pushed
the
debug-autowiring-class-aliases
branch
from
36a0972
to
d34b437
Compare
nicolas-grekas
approved these changes
Apr 21, 2020
nicolas-grekas
changed the title
chalasr
approved these changes
Apr 23, 2020
|
Thank you @weaverryan. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imagine that
FooInterfaceis an alias, but it is deprecated and so has aclass_aliastoBarInterface. Currently,debug:autowiringwill actually print that's the autowiring alias isBarInterface, despite there being no such id in the container.@nicolas-grekas originally (on purpose) made the 2nd argument to
Descriptor::getClassDescription()be passed by reference for this exact feature - 56aab09 - but I can't figure out why. This change (which effectively removes the by-reference modifying) made no existing tests fail.Discovered this because the whole deprecated
Doctrine\Common\Persistence\ManagerRegistryvs newerDoctrine\Persistence\ManagerRegistrycauses the issue.Thanks!