[Cache] Allow invalidateTags calls to be traced by data collector #36536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
changed the title
| if ($definition->isAbstract()) { | ||
| continue; | ||
| } | ||
| $this->addToCollector($id, $container); |
There was a problem hiding this comment.
don't we want to collect only the decorator when there is one?
There was a problem hiding this comment.
No, If we only collect the TagAwareAdapter, we lose the psr6 calls since the Adapter decorated by TagAwareAdapter calls these methods on itself.
src/Symfony/Component/Cache/DependencyInjection/CacheCollectorPass.php
Outdated
Show resolved
Hide resolved
This was referenced Apr 23, 2020
|
Fixes #34810? |
l-vo
force-pushed
the
add_tag_aware_adapters_to_collector
branch
from
0ed7fb2
to
28fdb3a
Compare
I haven't seen this issue, but yes, that fixes it. |
nicolas-grekas
approved these changes
Apr 26, 2020
|
Thank you @l-vo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TraceableTagAwareAdapteris not used in the fullstack framework since tag aware pools don't have thecache.pooltag (it's the decorated adapter that has it). This PR aims to useTraceableTagAwareAdapterwhen a pool is configured withtags: true