[PhpUnitBridge] fix compatibility with phpunit 9 #36539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
localheinz
reviewed
Apr 23, 2020
src/Symfony/Bridge/PhpUnit/Legacy/SymfonyTestsListenerTrait.php
Outdated
Show resolved
Hide resolved
localheinz
reviewed
Apr 23, 2020
src/Symfony/Bridge/PhpUnit/Legacy/SymfonyTestsListenerTrait.php
Outdated
Show resolved
Hide resolved
garak
force-pushed
the
fix-phpunit-blacklist
branch
from
a8dddc5
to
971e800
Compare
src/Symfony/Bridge/PhpUnit/Legacy/SymfonyTestsListenerTrait.php
Outdated
Show resolved
Hide resolved
|
Looks like |
Jean85
reviewed
Apr 23, 2020
src/Symfony/Bridge/PhpUnit/Legacy/SymfonyTestsListenerTrait.php
Outdated
Show resolved
Hide resolved
garak
force-pushed
the
fix-phpunit-blacklist
branch
from
88400b3
to
811daab
Compare
|
Added check in simple-phpunit too |
garak
force-pushed
the
fix-phpunit-blacklist
branch
from
67cdd07
to
3ad44bf
Compare
Jean85
approved these changes
Apr 23, 2020
garak
force-pushed
the
fix-phpunit-blacklist
branch
from
ffd0047
to
0ecae1e
Compare
src/Symfony/Bridge/PhpUnit/Legacy/SymfonyTestsListenerTrait.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
changed the title
garak
force-pushed
the
fix-phpunit-blacklist
branch
from
36213a5
to
3cc9aab
Compare
garak
force-pushed
the
fix-phpunit-blacklist
branch
from
aa5b23e
to
e27ed28
Compare
nicolas-grekas
approved these changes
Apr 24, 2020
fabpot
approved these changes
Apr 24, 2020
|
Thank you @garak. |
fabpot
added a commit
that referenced
this pull request
Apr 25, 2020
This PR was merged into the 3.4 branch. Discussion ---------- [PhpUnitBridge] Improve dirname usage | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | Fix #36499 | License | MIT This is a very small performance improvement on top of #36539 Commits ------- e721cfd Improve dirname usage
This was referenced Apr 28, 2020
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See related issue