Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cache] Fixed not supported Redis eviction policies #36606

Conversation

SerheyDolgushev
Copy link
Contributor

@SerheyDolgushev SerheyDolgushev commented Apr 28, 2020

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets no
License MIT
Doc PR no

Steps to reproduce:

  1. Define the following redis service on SymfonyCloud:
rediscache:
    type: redis:5.0
    size: S
    configuration:
        maxmemory_policy: allkeys-lru
  1. Deploy the change

Expected result:
No redis cache will be populated

Actual result:
Following exception is thrown:

[2020-04-28T05:35:58.440403-04:00] php.CRITICAL: Uncaught Error: Return value of Symfony\Component\Cache\Adapter\RedisTagAwareAdapter::doSave() must be of the type array, bool returned {"exception":"[object] (TypeError(code: 0): Return value of Symfony\\Component\\Cache\\Adapter\\RedisTagAwareAdapter::doSave() must be of the type array, bool returned at /app/vendor/symfony/cache/Adapter/RedisTagAwareAdapter.php:100)"} []

@nicolas-grekas nicolas-grekas added this to the 4.4 milestone Apr 28, 2020
@SerheyDolgushev SerheyDolgushev force-pushed the fix-cache-redis-not-supported-eviction-policies branch from 2a11d05 to 390554d Compare April 28, 2020 10:31
@SerheyDolgushev SerheyDolgushev changed the base branch from 5.0 to 4.4 April 28, 2020 10:31
@SerheyDolgushev
Copy link
Contributor Author

@nicolas-grekas rebased onto 4.4

@SerheyDolgushev SerheyDolgushev force-pushed the fix-cache-redis-not-supported-eviction-policies branch from af59e62 to 9faefec Compare April 28, 2020 11:12
@SerheyDolgushev SerheyDolgushev force-pushed the fix-cache-redis-not-supported-eviction-policies branch from 9faefec to 3d6e942 Compare April 28, 2020 11:14
@nicolas-grekas
Copy link
Member

Thank you @SerheyDolgushev.

@nicolas-grekas nicolas-grekas merged commit f8d3b06 into symfony:4.4 Apr 30, 2020
This was referenced May 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants