Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SendEmailMessage class marked as internal #36699

Closed
ricohumme opened this issue May 5, 2020 · 2 comments
Closed

SendEmailMessage class marked as internal #36699

ricohumme opened this issue May 5, 2020 · 2 comments
Labels
Mailer Status: Needs Review

Comments

@ricohumme
Copy link

Symfony version(s) affected: 4.4.*|5|master

Description
Currently the constructor for this class is still marked as internal, and I am wondering why that is?
Is it so that this is class is still subjected to change, or doesn't have BC promise?
I'm currently implementing this message in my application, and PHPStorm struck the classname, so I started to investigate.

I noticed users saying that PHPStorm should not strike these classes when marked as internal, but the question of changes and/or BC promise remains.

Thanks in advance.
@ricohumme ricohumme added the Bug label May 5, 2020
@xabbuh xabbuh added the Mailer label May 5, 2020
@Tobion Tobion removed the Bug label May 6, 2020
@fabpot fabpot mentioned this issue Jun 10, 2020
Merged
@fabpot
Copy link
Member

fabpot commented Jun 10, 2020

I think we can safely remove the annotation. That's a leftover from a previous version of my local code. Fixed in #37181

@fabpot fabpot closed this as completed Jun 10, 2020
@ricohumme
Copy link
Author

Thnx Fabien

fabpot added a commit that referenced this issue Jun 10, 2020
@fabpot
bug #37181 [Mailer] Remove an internal annot (fabpot)
5edbf0b 
This PR was merged into the 4.4 branch.

Discussion
----------

[Mailer] Remove an internal annot

| Q             | A
| ------------- | ---
| Branch?       | 4.4 <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | Fix #36699 <!-- prefix each issue number with "Fix #", if any -->
| License       | MIT
| Doc PR        | n/a

There is no reason to mark this method as being internal. Let's remove it.

Commits
-------

52161f3 [Mailer] Remove an internal annot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Mailer Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@fabpot @Tobion @xabbuh @ricohumme @carsonbot