Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint:container says that array is passed as 3rd argument to addListener, when it is an int #36750

Closed
kojidev opened this issue May 8, 2020 · 3 comments

Comments

@kojidev
Copy link

kojidev commented May 8, 2020

Symfony version(s) affected: 5.0.8

Description
I'm using sentry/sentry-symfony:3.5.0 (latest). When I run php bin/console lint:container -e prod
it complains that I'm trying to pass array value to int argument, and doesn't say where, thru debugging I figured it complains about sentry registering a listener, but parameter that sentry tries to pass is an integer, but gets reassigned to array here: https://github.com/symfony/dependency-injection/blob/b9f508fd25012361565ed6ad77600ad2ba64592c/Compiler/CheckTypeDeclarationsPass.php#L202

How to reproduce
Reproducer: https://github.com/kojidev/lint-repr

Possible Solution
I'm not familiar with symfony/di implementation, so Idk how to go about fixing it.

Additional context
For some reason it only happens in prod environment, even tho it doesn't seemed that sentry configures itself any different in either environment

@R11baka
Copy link

R11baka commented May 8, 2020

Hi! Tested on @kojidev reproducer. I can confirm this behavior!
status: reviewed

@nicolas-grekas
Copy link
Member

@fancyweb maybe?

@fancyweb
Copy link
Contributor

fancyweb commented Jul 8, 2020

@nicolas-grekas You can close, it was fixed by #37193.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants