[WebProfiler] Remove 'none' when appending CSP tokens #36786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @ndench |
|
Yep, seems to work as expected for me. I'm unsure why aappveyor is failing though. The only issue I can see is if someone specifies |
nicolas-grekas
approved these changes
May 12, 2020
fabpot
approved these changes
May 13, 2020
|
Thank you @ndench. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nicolas-grekas asked me to to have a look at this after #36678.
If a user has a CSP policy of
default-src 'none', then the WebProfiler copies'none'toscript-srcandstyle-srcthen adds other sources. This creates an invalid policy since'none'is only allowed when it's the only item in the source list.This will probably need to be merged into 3.4 first, I started on 4.4 so I can test in my current symfony project which requires 4.4.