Change priority of KernelEvents::RESPONSE subscriber #36789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Symfony/Component/HttpKernel/EventListener/ProfilerListener.php
Outdated
Show resolved
Hide resolved
fabpot
approved these changes
May 14, 2020
fabpot
force-pushed
the
make-profiler-listener-penultimate
branch
from
a379912
to
6ed624a
Compare
|
Thank you @marcw. |
Merged
This was referenced May 16, 2020
Closed
|
Looks like this PR has caused a regression: #36836. |
fabpot
added a commit
that referenced
this pull request
May 18, 2020
This PR was merged into the 4.4 branch. Discussion ---------- [HttpKernel] Bring back the debug toolbar | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #36836 | License | MIT | Doc PR | N/A This PR effectively reverts #36789 in order to fix a regression caused by that PR. Commits ------- 9f8d225 Revert "Change priority of KernelEvents::RESPONSE subscriber"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the priority of the
KernelEvents::RESPONSEsubscriber of theProfilerListenerso that it is the penultimate to be executed (just beforeStreamedResponseListener).The reason is that other listeners that were executed after this one CAN change the response (such as
SessionListenerfor example). This creates a headache when debugging, with a discrepancy between what is shown in a curl command, and by the Symfony profiler.