Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpKernel] Bring back the debug toolbar #36838

Merged
merged 1 commit into from May 18, 2020

Conversation

derrabus
Copy link
Member

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #36836
License MIT
Doc PR N/A

This PR effectively reverts #36789 in order to fix a regression caused by that PR.

@derrabus derrabus changed the title [HttpKernel] Revert "Change priority of KernelEvents::RESPONSE subscriber" [HttpKernel] Bring back the debug toolbar May 16, 2020
@chalasr chalasr added this to the 4.4 milestone May 16, 2020
@noniagriconomie
Copy link
Contributor

Can it be usefull to create a simple test where the priority of events are set and garanty that the order does not change when runing the test?
Because changing the priority should be something to do very carefuly imo, moreover core events

@derrabus
Copy link
Member Author

derrabus commented May 17, 2020

This PR reverts the priorities to the state of 4.4.8, which should be a safe change.

Apart from that, yes: Some kind of integration test that prevents future regressions would make sense here.

@fabpot
Copy link
Member

fabpot commented May 18, 2020

Thank you @derrabus.

@fabpot fabpot merged commit 87c6683 into symfony:4.4 May 18, 2020
@derrabus derrabus deleted the bugfix/debug-toolbar branch May 18, 2020 08:51
This was referenced May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants