[BrowserKit] Raw body with custom Content-Type header

[azhurb]

Q	A
Branch?	4.4
Bug fix?	yes
New feature?	no
Deprecations?	no
License	MIT

Currently, if you try to send POST/PUT request with custom Content-Type header and specified body, the real request will contain text/plain content type.

Following code

$client->request(
    'POST',
    '/url',
    [],
    [],
    [
        'CONTENT_TYPE' => 'application/json'
    ],
    '{"foo":"bar"}'
);

produces next request

POST /
Content-Type: text/plain; charset=utf-8

{"foo":"bar"}

With this fix, the request will be

POST /
Content-Type: application/json

{"foo":"bar"}

[ro0NL]

Hi @azhurb, looks like it fixes #36640 :) cool.

WDYT of my patch suggestion in the issue? I believe there are some other cases where we need to preserve the given content-type as well.

[nicolas-grekas]

Thanks. Here is some nitpicking.

[azhurb]

Hi @azhurb, looks like it fixes #36640 :) cool.

WDYT of my patch suggestion in the issue? I believe there are some other cases where we need to preserve the given content-type as well.

Hi @ro0NL. Actually I believe we need to preserve content-type only if the raw body data is not empty. It looks like other cases are already covered. Anyway, your patch should work as well :)

[azhurb]

There is also discussion from 2016 about this issue #20042

[fabpot]

Thank you @azhurb.