[Form] validate subforms in all validation groups #36865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
May 19, 2020
xabbuh
commented
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix #36852 |
| License | MIT |
| Doc PR |
xabbuh
commented
May 19, 2020
| @@ -86,7 +86,8 @@ public function validate($form, Constraint $formConstraint) | |||
| // sequence recursively, thus some fields could fail | |||
| // in different steps without breaking early enough | |||
| $this->resolvedGroups[$field] = (array) $group; | |||
| $validator->atPath(sprintf($fieldPropertyPath, $field->getPropertyPath()))->validate($field, $formConstraint); | |||
| $fieldFormConstraint = new Form(); | |||
There was a problem hiding this comment.
This is needed for now to prevent hash collisions (see also #36415).
xabbuh
commented
May 19, 2020
| @@ -37,7 +38,7 @@ public function __construct(ValidatorInterface $validator) | |||
|
|
|||
| /* @var $metadata ClassMetadata */ | |||
| $metadata->addConstraint(new Form()); | |||
| $metadata->addPropertyConstraint('children', new Valid()); | |||
| $metadata->traversalStrategy = TraversalStrategy::NONE; | |||
There was a problem hiding this comment.
traversal happens explicitly inside the FormValidator
xabbuh
force-pushed
the
issue-36852
branch
3 times, most recently
from
d17a4d2
to
2fa63a5
Compare
|
This is ready to be reviewed. |
xabbuh
force-pushed
the
issue-36852
branch
3 times, most recently
from
68fcedb
to
27d9f82
Compare
|
/cc @HeahDude |
stof
reviewed
May 28, 2020
src/Symfony/Component/Form/Extension/Validator/Constraints/FormValidator.php
Outdated
Show resolved
Hide resolved
stof
reviewed
May 28, 2020
src/Symfony/Component/Form/Extension/Validator/ValidatorExtension.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
approved these changes
May 30, 2020
|
Thank you @xabbuh. |
This was referenced May 31, 2020
Merged
Merged
Merged
Merged
|
This breaks property mapping in some way. |
|
Maybe the same as #37027? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.