Address deprecation of ReflectionType::getClass() #36891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What should I do about the fabbot failures? They're unrelated to my changes. Submit a separate PR to fix them or ignore them? |
|
They are false positives. We could rewrite the code a bit to prevent fabbot from generating these patches (using concat I guess). In this PR or another as you wish. |
derrabus
force-pushed
the
bugfix/get-class-deprecation
branch
from
32443e4
to
53b1677
Compare
|
Test failures on php 5.5 have been resolved. Travis is green now. |
derrabus
commented
May 21, 2020
derrabus
commented
May 21, 2020
|
Thank you @derrabus. |
nicolas-grekas
added a commit
that referenced
this pull request
May 23, 2020
…eflectionParameter::getClass() (derrabus) This PR was merged into the 4.4 branch. Discussion ---------- [OptionsResolver][Serializer] Remove calls to deprecated ReflectionParameter::getClass() | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | #36872 | License | MIT | Doc PR | N/A Following #36891, this PR removes the remaining calls to `ReflectionParameter::getClass()` from the 4.4 branch. Commits ------- 1575d85 Remove calls to deprecated ReflectionParameter::getClass().
This was referenced May 26, 2020
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
ReflectionType::getClass()will trigger a deprecation warning on php 8. This PR switches togetType()if available.