Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VarDumper] ReflectionFunction::isDisabled() is deprecated #36899

Merged

Conversation

derrabus
Copy link
Member

@derrabus derrabus commented May 22, 2020

Q A
Branch? 3.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets #36872
License MIT
Doc PR N/A

See php/php-src#5473. Calling ReflectionFunction::isDisabled() is pointless on php 8 and doing so triggers a deprecation warning.

Someone who is more familiar with that component might want to have a second look on this PR. I'm not really sure if this is the right way to fix the issue.

@nicolas-grekas
Copy link
Member

I would suggest to patch addMap instead:

if (\PHP_VERSION_ID >= 80000 && 'isDisabled' === $m) {
    continue;
}

@derrabus derrabus force-pushed the bugfix/function-is-disabled-deprecation branch from 9c21cfd to 1da347e Compare May 22, 2020 18:50
@nicolas-grekas
Copy link
Member

Thank you @derrabus.

@nicolas-grekas nicolas-grekas merged commit fb91dc2 into symfony:3.4 May 23, 2020
@derrabus derrabus deleted the bugfix/function-is-disabled-deprecation branch May 23, 2020 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants