Fixes sprintf(): Too few arguments in form transformer

[pedrocasado]

Similar to: #29482

Q	A
Branch?	3.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	none
License	MIT
Doc PR	none

Fixes the form reverse transformation when the method viewToNorm is called within a value with the character %:

Before : "sprintf(): Too few arguments"

After : Form reverse transformation works.

Reference : http://php.net/manual/function.sprintf.php

[xabbuh]

Can we add a test case to prevent future regressions (IIRC this was done recently to satisfy fabbot.io)?

[ro0NL]

Hi @pedrocasado can you also have a look at #36954 maybe :)

[Tobion]

Seems like most (all?) of this was already fixed, e.g. in #36684
You need to rebase.

[Tobion]

Please add a test as suggested by @xabbuh for at least one case like the Form transformation.

[pedrocasado]

@Tobion , can you give me some guidance? do you think this test is enough?

public function testDataTransformationEscapesValueCorrectlyInException()
{
    $this->expectException('Symfony\Component\Form\Exception\TransformationFailedException');
    $this->expectExceptionMessage('Unable to transform data for property path "name": No mapping for value "90%"');
    $model = new FixedDataTransformer([
        'default' => 'foo',
    ]);
    $view = new FixedDataTransformer([
        'foo' => 'bar',
    ]);

    $config = new FormConfigBuilder('name', null, $this->dispatcher);
    $config->addViewTransformer($view);
    $config->addModelTransformer($model);
    $config->setData('90%');
    $form = new Form($config);

    $form->getData();
}

[nicolas-grekas]

(let's skip adding tests for this...)

[nicolas-grekas]

Thank you @pedrocasado.